Skip to content
This repository has been archived by the owner on Jul 20, 2023. It is now read-only.

Serial over LAN (SoL) layout is broken #125

Open
Kostr opened this issue Nov 1, 2020 · 2 comments
Open

Serial over LAN (SoL) layout is broken #125

Kostr opened this issue Nov 1, 2020 · 2 comments

Comments

@Kostr
Copy link
Contributor

Kostr commented Nov 1, 2020

Serial over LAN (SoL) element takes too little window space (opposed to KVM for example):
2020-11-01_15-27-55

If it is an intention, everything looks especially broken, when SoL is opened in a new window:
2020-11-01_15-29-01

Besides it is too small and aligned left, you can see, that terminal doesn't use full window space for its output

@gtmills
Copy link
Member

gtmills commented Nov 5, 2020

This was on the mailing list here: https://lists.ozlabs.org/pipermail/openbmc/2020-November/023891.html

@Kostr
Copy link
Contributor Author

Kostr commented Nov 6, 2020

Some screenshots for the proposed commit (https://gerrit.openbmc-project.xyz/c/openbmc/phosphor-webui/+/38036)

I didn't touched fixed height of the terminal in the main SoL tab. The terminal still takes 25em in height:
2020-11-06_18-10-49

But I've added responsiveness, so the terminal content resizes when the window gets shorter than a default terminal width:
2020-11-06_18-11-17

The main changes are in the separate SoL window. It opens like before in 640x550, but now:
-XTERM always use full terminal viewport space
-terminal viewport width always equals window space width
-terminal viewport automatically resizes on window size changes
-terminal content automatically resizes with the viewport changes
2020-11-06_18-11-46
2020-11-06_18-13-19

As SOL UI is resposive now, this commit also removes fixed size configurations for the SOL terminal via JSON 'customConsoleDisplaySize' variable. It is worth noting that in reality it wasn't used by anybody.

Also I want to note, that I'm not a professional UI designer, I did this change for myself, and added this commit just in case it would be useful for anybody else in the OpenBMC community.

geissonator pushed a commit that referenced this issue Jul 14, 2021
The current version of a SOL window layout have several
downsides:
-terminal content doesn't resize with the window changes
-when opened in a separate window terminal content doesn't
use full viewport space
-when opened in a separate window terminal viewport takes
only a small part of the window

Screenshots with the problems descriptions are documented in
the github issue:
#125

This commit adds responsiveness to the SOL layout.
The main SOL tab:
-terminal content automatically resizes with the viewport changes

The separate SOL window:
-XTERM always use full terminal viewport space
-terminal viewport width always equals window space width
-terminal viewport automatically resizes on window size changes
-terminal content automatically resizes with the viewport changes

As SOL UI is resposive now, this commit also removes fixed size
configurations for the SOL terminal via JSON 'customConsoleDisplaySize'
variable. It is worth noting that in reality it wasn't really
used anyway.

Signed-off-by: Konstantin Aladyshev <[email protected]>
Change-Id: Ia5d929e9a309281366a9d3119ac326ebd73c73f0
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants