Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PharmacoGenomics_0123 #304

Merged
merged 8 commits into from
Feb 13, 2024
Merged

PharmacoGenomics_0123 #304

merged 8 commits into from
Feb 13, 2024

Conversation

mugpeng
Copy link
Contributor

@mugpeng mugpeng commented Jan 23, 2024

@ShixiangWang
Copy link
Member

@mugpeng Thanks for your PR.

@lishensuo Please take a look and test for potential optimization and updates.

@ShixiangWang
Copy link
Member

最近我会先根据 https://github.com/mugpeng/OmicsPharDB 给你一些 comments 看看你那边还能不能优化 @mugpeng 文章会把这部分纳入,你有空配合下申锁 @lishensuo 准备下相关的数据/材料哈。

这个 PR 我跟申锁聊过了,由于 app.R preprocess 数据大的原因目前特别是对于本地安装使用该 shiny 可能会造成困扰,我会在一个月内抽空解决这个问题(无论是好方案坏方案),然后再执行合并操作。

@mugpeng
Copy link
Contributor Author

mugpeng commented Jan 26, 2024

OK,咱们直接在群里沟通吧。github 看的可能不够及时。

@ShixiangWang
Copy link
Member

OK,咱们直接在群里沟通吧。github 看的可能不够及时。

可以

use spearman cor, and log2(Odds)
@ShixiangWang
Copy link
Member

标记下跟数据有关的变量:

omics_search_list1
omics_search_list2
omics_search_list1_sel
omics_search_list2_sel
profile
profile1
profile2

@ShixiangWang ShixiangWang merged commit a3c5a5c into openbiox:master Feb 13, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants