Add Python 3 compatibility #71
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've now also tested using BTLE with Ganglion (via user.py) and it works for both Python 2.7 and Python 3. |
|
Thanks so much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now works in Python 3.x and still backwards compatible with Python 2.7.x.
I've only implemented this when using Ganglion via Wifi, so it may not work on other paths, such as via user.py, but everything should still work on Python 2.7.x. Did fix up all the print statements for Python 3 though. #56
With user.py, tested and can confirm it works until it tries to scan Bluetooth devices but did not test further as I did not have this setup.