Fix cross platform issues #113
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #113 +/- ##
=======================================
Coverage 37.35% 37.35%
=======================================
Files 9 9
Lines 1585 1585
=======================================
Hits 592 592
Misses 993 993
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the changes discussed in #112. Specifically removing bluepy from
requirements.txt, adding a section in theREADMEabout the need to install it to use the Ganglion code, and adding a ifsys.platform == "linux"check to import ganglion in__init__.pyto allow all code except Ganglion to be used on all platforms.Resolves #39, resolves #68, resolves #72, resolves #86, resolves #98, resolves #112.