Screenshots not working with Android 23

[gregersn]

At some point between the current version (2.7.2) and 2.3.1 screenshots with Android 23 (on emulator) is no longer working.
I see there has been some back and forth with the screenshot function since then, but some of the changes has made it no longer usable with Android 23.

[codeskyblue]

Is "adb shell screencap" works?

[gregersn]

It works, but it does not give a valid image file. And the error message when using the newer version of adbutils seems to be that it does not recognize the data returned/is unable to determine the image format.

…

On Wed, Jun 12, 2024 at 6:59 AM codeskyblue ***@***.***> wrote: Is "adb shell screencap" works? — Reply to this email directly, view it on GitHub <#133 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAKNDW47HQLKHMUKGTR2EUTZG7IURAVCNFSM6AAAAABJCHWWCGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNRSGEYDONZVGI> . You are receiving this because you authored the thread.Message ID: ***@***.***>

-- Greger http://gregerstoltnilsen.net

[Gennadiyev]

I have not investigated whether it is an Android 23 problem or some ADB version problem. If you run into some error like:

screencap error: cannot identify image file <_io.BytesIO object at 0x000002202178E2A0>

TL;DR: Then your fix could be as simple as passing a display_id parameter to Device.screenshot method.

---

If you dive deeper to the bytes provided by the __screencap function, you will see these lines at the top of the output file:

[Warning] Multiple displays were found, but no display id was specified! Defaulting to the first display found, however this default is not guaranteed to be consistent across captures. A display id should be specified.
A display ID can be specified with the [-d display-id] option.
See "dumpsys SurfaceFlinger --display-id" for valid display IDs.

Followed by a PNG byte sequence. So the solution is quite trivial.