This repository was archived by the owner on Feb 18, 2025. It is now read-only.
Include port in DiscoveryIgnoreReplicaHostnameFilters regexp matching #952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eplicaHostnameFilters.
…veryIgnoreReplicaHostnameFilters.
shlomi-noach
approved these changes
Aug 6, 2019
| @@ -18,7 +18,8 @@ | |||
| "InstancePollSeconds": 5, | |||
| "DiscoveryIgnoreReplicaHostnameFilters": [ | |||
| "a_host_i_want_to_ignore[.]example[.]com", | |||
| ".*[.]ignore_all_hosts_from_this_domain[.]example[.]com" | |||
| ".*[.]ignore_all_hosts_from_this_domain[.]example[.]com", | |||
| "a_host_with_extra_port_i_want_to_ignore[.]example[.]com:3307" | |||
There was a problem hiding this comment.
Thanks for adding an example!
shlomi-noach
temporarily deployed
to
production/mysql_cluster=conductor
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #923
This PR simply extends the hostname matching for the
DiscoveryIgnoreReplicaHostnameFiltersconfig setting to also include a server's port. By allowing the match on port number as well as hostname, you can prevent any replica instances (or transient gh-ost processes) which connect on a secondary port from showing up in Orchestrator by using a config setting like this:Notes:
gofmt(please avoidgoimports)./build.shgo test ./go/...