This repository was archived by the owner on Feb 18, 2025. It is now read-only.
Forget instance: accept fuzzy/partial hostnames #886
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
forget
requiredfqdn
of the instance to forget. The reasoning was that we wanted to avoid resolving the name, which would lead us to forgetting a different name than the name submitted to be forgotten, e.g. if we wanted to forget an old DNS name.This PR now allows fuzzy/partial names in
forget
.orchestrator
will attempt to find a single-matching instance, and without running name resolving.Thus,
orchestrator-client -c forget -i my-host-123
will succeed if a hostnamemy-host-123456.example.com
exists and is the only server to match the partial name.If both
my-host-123456.example.com
andmy-host-123abc.example.com
exist, that's an ambiguity and the operation aborts.cc @ggunson