Skip to content

Support ALTER ONLINE TABLE syntax#9

Closed
shlomi-noach wants to merge 2 commits intomasterfrom
alter-online-table
Closed

Support ALTER ONLINE TABLE syntax#9
shlomi-noach wants to merge 2 commits intomasterfrom
alter-online-table

Conversation

@shlomi-noach
Copy link
Copy Markdown

This PR supports an experimental syntax: ALTER ONLINE TABLE ..., which has the same syntax as ALTER TABLE except for the addition of ONLINE.

This syntax isn't supported by MySQL: it is a Vitess experiment (PR link to follow) with special magic syntax. To that effect, gh-ost will silently accept --alter="alter online table ..." syntax as valid. It otherwise doesn't do anything special if the word ONLINE appears.

@shlomi-noach
Copy link
Copy Markdown
Author

Context: vitessio/vitess#6547

@shlomi-noach
Copy link
Copy Markdown
Author

There is no need for this PR. Vitess can send the alter_options part of the ALTER TABLE statement.

@shlomi-noach shlomi-noach deleted the alter-online-table branch September 6, 2020 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant