feat(issue-94): adds support for requestBody validation with multiple media-types #800
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
| // TODO: Implement matching on RFC 7231 media-range, e.g. "image/*", "*/*" | ||
| // see: https://swagger.io/specification/#request-body-object | ||
| if (mediaTypes.includes(contentType)) { |
There was a problem hiding this comment.
Sorry if I'm missing something, or if this is the wrong place to ask. From my testing (and maybe RFC 2046?) multipart/form-data requests will always include the boundary in the content-type header (example multipart/form-data; boundary=---------.... So I don't think this matches the validator media type for multipart requests. Maybe something like if (mediaTypes.includes(contentType.split(';')[0].trim()) would still work?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #94. Adds support for multiple Media Type Object content body.
Previously, if
requestBody.contentdefined multiple content types, e.g.application/jsonandmultipart/form-data, then onlyapplication/jsonwould be used to validate the request. Now, a request with a content-type ofapplication/jsonwill validate against the schema associated with theapplication/jsonmedia-type, and a request ofmultipart/form-datawill validate against the associated media-type schema.If no
content-typeis specified, then the default behaviour remains unchanged - it will default to the first content media-type.Currently, media-type matching is not supported, e.g.
text/*.