Skip to content

Add support for booleans and floats in OpenAPI Schema const #1086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 25, 2024
Merged

Add support for booleans and floats in OpenAPI Schema const #1086

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
a6df8d2
feat: Add support for booleans in OpenAPI Schema `const`
Jul 31, 2024
88ced4d
support float as well
Jul 31, 2024
8b8ce9d
Merge branch 'main' into feat/support-bool-on-const
flxdot Aug 7, 2024
9eaf5c1
Merge branch 'main' into feat/support-bool-on-const
flxdot Aug 20, 2024
2e360da
Fix type annotation & add changeset
dbanty Aug 25, 2024
c2d7ecd
Merge branch 'main' into feat/support-bool-on-const
dbanty Aug 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions openapi_python_client/schema/openapi_schema_pydantic/schema.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
from typing import Any, Dict, List, Optional, Union

from pydantic import BaseModel, ConfigDict, Field, StrictInt, StrictStr, model_validator
from pydantic import BaseModel, ConfigDict, Field, StrictBool, StrictFloat, StrictInt, StrictStr, model_validator

from ..data_type import DataType
from .discriminator import Discriminator
Expand Down Expand Up @@ -36,7 +36,7 @@ class Schema(BaseModel):
minProperties: Optional[int] = Field(default=None, ge=0)
required: Optional[List[str]] = Field(default=None, min_length=1)
enum: Union[None, List[Any]] = Field(default=None, min_length=1)
const: Union[None, StrictStr, StrictInt] = None
const: Union[None, StrictStr, StrictInt, StrictFloat, StrictBool] = None
type: Union[DataType, List[DataType], None] = Field(default=None)
allOf: List[Union[Reference, "Schema"]] = Field(default_factory=list)
oneOf: List[Union[Reference, "Schema"]] = Field(default_factory=list)
Expand Down
5 changes: 5 additions & 0 deletions tests/test_schema/test_schema.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,11 @@ def test_nullable_with_allof():
assert schema.allOf == []


def test_constant_bool():
schema = Schema.model_validate_json('{"type":"boolean", "enum":[true], "const":true, "default":true}')
assert schema.const is True


def test_nullable_with_type_list():
schema = Schema.model_validate_json('{"type": ["string", "number"], "nullable": true}')
assert schema.type == [DataType.STRING, DataType.NUMBER, DataType.NULL]
Expand Down