Skip to content
This repository was archived by the owner on Aug 28, 2025. It is now read-only.

Dwtest/track2#2920

Merged
dw511214992 merged 2 commits intomasterfrom
dwtest/track2
Jun 15, 2021
Merged

Dwtest/track2#2920
dw511214992 merged 2 commits intomasterfrom
dwtest/track2

Conversation

@dw511214992
Copy link

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Please ensure to add changelog with this PR by answering the following questions.

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
  3. When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
  4. If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No, no need to refresh for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

    • Adding new API(s)
    • Adding a new API version
    • Ensure to copy the existing version into new directory structure for first commit (including refactoring) and then push new changes including version updates in separate commits. This is required to review the changes efficiently.
    • Adding a new service
  • Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in stable version
  • Removing properties in stable version
  • Removing API version(s) in stable version
  • Updating API in stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@openapi-pipeline-app-test
Copy link

openapi-pipeline-app-test bot commented Jun 15, 2021

Swagger Validation Report

️❌BreakingChange: 1 Errors, 0 Warnings failed [Detail]
Rule Message
1040 - AddedReadOnlyPropertyInResponse The new version has a new read-only property 'resourcetest' in response that was not found in the old version.
New: Microsoft.IoTSpaces/preview/2017-10-01-preview/iotspaces.json#L639:7
Old: Microsoft.IoTSpaces/preview/2017-10-01-preview/iotspaces.json#L639:7
️⚠️LintDiff: 0 Warnings warning [Detail]
The following errors/warnings exist before current PR submission:

Only 10 items are listed, please refer to log for more details.

Rule Message
R3021 - PathResourceTypeNameCamelCase Resource type naming must follow camel case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.IoTSpaces/Graph/{resourceName}'
Location: Microsoft.IoTSpaces/preview/2017-10-01-preview/iotspaces.json#L40
R3021 - PathResourceTypeNameCamelCase Resource type naming must follow camel case. Path: '/subscriptions/{subscriptionId}/providers/Microsoft.IoTSpaces/Graph'
Location: Microsoft.IoTSpaces/preview/2017-10-01-preview/iotspaces.json#L238
R3021 - PathResourceTypeNameCamelCase Resource type naming must follow camel case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.IoTSpaces/Graph'
Location: Microsoft.IoTSpaces/preview/2017-10-01-preview/iotspaces.json#L278
R4007 - DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
Location: Microsoft.IoTSpaces/preview/2017-10-01-preview/iotspaces.json#L73
R4007 - DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
Location: Microsoft.IoTSpaces/preview/2017-10-01-preview/iotspaces.json#L127
R4007 - DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
Location: Microsoft.IoTSpaces/preview/2017-10-01-preview/iotspaces.json#L181
R4007 - DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
Location: Microsoft.IoTSpaces/preview/2017-10-01-preview/iotspaces.json#L229
R4007 - DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
Location: Microsoft.IoTSpaces/preview/2017-10-01-preview/iotspaces.json#L268
R4007 - DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
Location: Microsoft.IoTSpaces/preview/2017-10-01-preview/iotspaces.json#L311
R4007 - DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
Location: Microsoft.IoTSpaces/preview/2017-10-01-preview/iotspaces.json#L348
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand]
There are no breaking changes.
️🔄CredScan inProgress [Detail]
️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️❌[Staging] SpellCheck: 1 Errors, 0 Warnings failed [Detail]
Rule Message
HowToFix Unknown word (resourcetest), please fix the error or add words to ./custom-words.txt
path: Microsoft.IoTSpaces/preview/2017-10-01-preview/iotspaces.json#L650:10
Posted by Swagger Pipeline | How to fix these errors?

@openapi-pipeline-app-test
Copy link

openapi-pipeline-app-test bot commented Jun 15, 2021

Swagger Generation Artifacts

️️✔️[Staging] ApiDocPreview succeeded [Detail] [Expand]
 Please click here to preview with your @microsoft account. 
️️✔️[Staging] SDK Breaking Change Tracking succeeded [Detail] [Expand]

Breaking Changes Tracking

️✔️azure-sdk-for-go - preview/iotspaces/mgmt/2017-10-01-preview/iotspaces - v55.1.0
️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]
  • ️✔️Succeeded [Logs]Release - Generate from 7edcbe8. SDK Automation 14.0.0
    warn	Skip initScript due to not configured
    command	sudo apt-get install -y dotnet-sdk-5.0
    command	autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.84 --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/iotspaces/resource-manager/readme.md
    cmderr	[Autorest] realpath(): Permission denied
    cmderr	[Autorest] realpath(): Permission denied
    cmderr	[Autorest] realpath(): Permission denied
    cmderr	[Autorest] realpath(): Permission denied
    cmderr	[Autorest] realpath(): Permission denied
    cmderr	[Autorest] realpath(): Permission denied
  • ️✔️Microsoft.Azure.Management.IoTSpaces [View full logs]  [Release SDK Changes]
    warn	Skip artifact folder because it doesn't exist: artifacts/packages
️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
  • ️✔️Succeeded [Logs]Release - Generate from 7edcbe8. SDK Automation 14.0.0
    command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
    command	generator automation ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
  • ️✔️preview/iotspaces/mgmt/2017-10-01-preview/iotspaces [View full logs]  [Release SDK Changes]
    info	[Changelog] ### Breaking Changes
    info	[Changelog]
    info	[Changelog] ### New Content
    info	[Changelog]
    info	[Changelog] - New field `Resourcetest` in struct `OperationDisplay`
    info	[Changelog]
    info	[Changelog] Total 0 breaking change(s), 1 additive change(s).
    info	[Changelog]
️❌ azure-sdk-for-js-track2 failed [Detail]
  • Failed [Logs]Release - Generate from 7edcbe8. SDK Automation 14.0.0
    warn	Skip initScript due to not configured
    command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
    error	Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-js]: sh .scripts/automation_generate.sh
    warn	Skip package processing as generation is failed
Posted by Swagger Pipeline | How to fix these errors?

@dw511214992 dw511214992 merged commit 7edcbe8 into master Jun 15, 2021
dw511214992 added a commit that referenced this pull request Jun 15, 2021
dw511214992 added a commit that referenced this pull request Jun 15, 2021
@dw511214992 dw511214992 deleted the dwtest/track2 branch June 15, 2021 06:48
azure-sdk pushed a commit that referenced this pull request Jun 16, 2021
* Update readme.md

* Update iotspaces.json
azure-sdk pushed a commit that referenced this pull request Jun 16, 2021
azure-sdk pushed a commit that referenced this pull request Jun 18, 2021
* Update readme.md

* Update iotspaces.json
azure-sdk pushed a commit that referenced this pull request Jun 18, 2021
azure-sdk pushed a commit that referenced this pull request Jun 19, 2021
* Update readme.md

* Update iotspaces.json
azure-sdk pushed a commit that referenced this pull request Jun 28, 2021
* Update readme.md

* Update iotspaces.json
azure-sdk pushed a commit that referenced this pull request Jun 28, 2021
azure-sdk pushed a commit that referenced this pull request Jun 29, 2021
* Update readme.md

* Update iotspaces.json
azure-sdk pushed a commit that referenced this pull request Jun 29, 2021
azure-sdk pushed a commit that referenced this pull request Jul 1, 2021
* Update readme.md

* Update iotspaces.json
azure-sdk pushed a commit that referenced this pull request Jul 1, 2021
azure-sdk pushed a commit that referenced this pull request Jul 10, 2021
* Update readme.md

* Update iotspaces.json
azure-sdk pushed a commit that referenced this pull request Jul 10, 2021
azure-sdk pushed a commit that referenced this pull request Jul 13, 2021
* Update readme.md

* Update iotspaces.json
azure-sdk pushed a commit that referenced this pull request Jul 13, 2021
azure-sdk pushed a commit that referenced this pull request Jul 14, 2021
* Update readme.md

* Update iotspaces.json
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant