-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fantastic idea, Is there any plans to make this work with new wordpress versions? #12
Comments
At the moment I made fork and trying to update pluging for new versions support.) |
The main change that is necessary - update authorization to match http://docs.annotatorjs.org/en/v1.2.x/authentication.html It's quite simple. But I had no expirience of developing WP plugins. Hope that 2-3 days would be enough to investigate and make changes. |
Even faster then I thought - seems to be working. You can check my fork: I'm using wordpress 4.3.1 |
@denis-aes want to submit a pull request? |
If the plugin would be alive and I would like to make single fix - that would be the best option. So, I the license allows - I think forking is better at the moment. What would you say? |
Hello, I have it working on WordPress 4.5.2. If you add me as a contributor in the repo (xyulex) I can upload the fixes for you. Thanks. |
I've got also working up-to-date version of annotator 1.x for wordpress. On Thu, May 12, 2016 at 12:24 PM, Raúl Martínez [email protected]
Всего наилучшего, Обыденных Денис |
Wondering if there's any plans to update. Working on 4.7.1 and it just crashes the whole site. |
Who's still around and interested in taking over responsibility for this project? My preference would be to see someone issue concise, clean pull requests, demonstrating their ability to manage the code base well. Then I'm happy to hand out a couple contributor permissions and see this in good hands that have more investment in it than I do. |
I may try to estimate the effort and make an actual contribution. And after
this we together can consider whether I will support the project.
ср, 25 янв. 2017 г. в 2:28, Randall Leeds <[email protected]>:
… Who's still around and interested in taking over responsibility for this
project? My preference would be to see someone issue concise, clean pull
requests, demonstrating their ability to manage the code base well. Then
I'm happy to hand out a couple contributor permissions and see this in good
hands that have more investment in it than I do.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#12 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABQFcPcQGmxwertrYBfuuJ7iytL4xncpks5rVokwgaJpZM4GRAmW>
.
|
Thanks! Let me know if there's anything I can do to help. I'm sorry I never merged your PR. If we can do some small cleanups in incremental steps I'll happily review and help merge, it's just very hard to evaluate big pull requests when I have limited bandwidth for this project. I want to see it stay maintainable, but give control over to those who have energy and enthusiasm for it. |
Fantastic idea, Is there any plans to make this work with new wordpress versions?
The text was updated successfully, but these errors were encountered: