Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fantastic idea, Is there any plans to make this work with new wordpress versions? #12

Open
fsonmez opened this issue Oct 18, 2015 · 11 comments

Comments

@fsonmez
Copy link

fsonmez commented Oct 18, 2015

Fantastic idea, Is there any plans to make this work with new wordpress versions?

@denisoby
Copy link

At the moment I made fork and trying to update pluging for new versions support.)

@denisoby
Copy link

The main change that is necessary - update authorization to match http://docs.annotatorjs.org/en/v1.2.x/authentication.html

It's quite simple. But I had no expirience of developing WP plugins.

Hope that 2-3 days would be enough to investigate and make changes.

@denisoby
Copy link

Even faster then I thought - seems to be working. You can check my fork:
https://github.com/denis-aes/annotator-wordpress

I'm using wordpress 4.3.1

@tilgovi
Copy link
Member

tilgovi commented Oct 28, 2015

@denis-aes want to submit a pull request?

@denisoby
Copy link

If the plugin would be alive and I would like to make single fix - that would be the best option.
But I have ideas of futher functionality improvements, and would like to take care of support.

So, I the license allows - I think forking is better at the moment.

What would you say?

@xyulex
Copy link

xyulex commented May 12, 2016

Hello,

I have it working on WordPress 4.5.2.

If you add me as a contributor in the repo (xyulex) I can upload the fixes for you.

Thanks.

@denisoby
Copy link

I've got also working up-to-date version of annotator 1.x for wordpress.
And can share them.

On Thu, May 12, 2016 at 12:24 PM, Raúl Martínez [email protected]
wrote:

Hello,

I have it working on WordPress 4.5.2.

If you add me as a contributor in the repo (xyulex) I can upload the fixes
for you.

Thanks.


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#12 (comment)

Всего наилучшего, Обыденных Денис
ICQ: 40-10-808 Skype: denis.obydennykh
http://avtomurmansk.ru/

@rwdbrooks
Copy link

Wondering if there's any plans to update. Working on 4.7.1 and it just crashes the whole site.

@tilgovi
Copy link
Member

tilgovi commented Jan 24, 2017

Who's still around and interested in taking over responsibility for this project? My preference would be to see someone issue concise, clean pull requests, demonstrating their ability to manage the code base well. Then I'm happy to hand out a couple contributor permissions and see this in good hands that have more investment in it than I do.

@denisoby
Copy link

denisoby commented Jan 24, 2017 via email

@tilgovi
Copy link
Member

tilgovi commented Jan 24, 2017

Thanks! Let me know if there's anything I can do to help. I'm sorry I never merged your PR. If we can do some small cleanups in incremental steps I'll happily review and help merge, it's just very hard to evaluate big pull requests when I have limited bandwidth for this project. I want to see it stay maintainable, but give control over to those who have energy and enthusiasm for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants