Skip to content

Fix test_long_examples_validator #406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Fix test_long_examples_validator #406

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
52f7c46
Check empty string
tuliren Apr 19, 2023
27fc715
Use startswith
tuliren Jul 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion openai/validators.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -423,7 +423,7 @@ def completions_space_start_validator(df):

def add_space_start(x):
x["completion"] = x["completion"].apply(
lambda x: ("" if x[0] == " " else " ") + x
lambda x: ("" if x == "" or x[0] == " " else " ") + x

This comment was marked as resolved.

Sign in to view

Copy link
Contributor Author

@tuliren tuliren Jul 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the suggestion. I have updated the PR. Also I changed the x in the lambda to s so that it does not clash with the input parameter x.

Copy link

@EliahKagan EliahKagan Jul 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I've verified that (as before) this makes the test pass when applied on top of b82a3f7.

)
return x

Expand Down