Fix API requestor hanging when not using a global session #167
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddeville
force-pushed
the
damien/async-session-fix
branch
from
79ee0ba to
3c07c16
Compare
hallacy
approved these changes
Jan 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a global session wasn't set in
openai.aiosession, we would create a tempClientSessionon the fly. Unfortunately, this session wasn't scoped correctly since it was closed upon returning fromarequest_rawbut_interpret_async_responsewould later callawait result.read()on the response, which would hang since the backing session had already been closed.This patch ensures that the session is kept open for the duration of the request and the entire parsing of the response.