Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): make it clearer that _get_azure_ad_token() returns a str #1460

Merged
merged 1 commit into from
Jun 2, 2024

Conversation

SelimWaly
Copy link
Contributor

Identify returned "token" as string.

  • I understand that this repository is auto-generated and my pull request may not be merged

Changes being requested

  • Set function _get_azure_ad_token() return statement value type as str.

Additional context & links

  • Should fix CI / lint workflow

Identify returned "token" as string.
@SelimWaly SelimWaly requested a review from a team as a code owner June 2, 2024 13:24
@rattrayalex rattrayalex changed the title Fix Azure Ad Token Function's Return Value Type fix(types): make it clearer that _get_azure_ad_token() returns a str Jun 2, 2024
@rattrayalex rattrayalex changed the base branch from main to next June 2, 2024 20:48
@rattrayalex
Copy link
Collaborator

Thank you for the contribution!

@rattrayalex rattrayalex merged commit 978a1d3 into openai:next Jun 2, 2024
2 checks passed
stainless-app bot pushed a commit that referenced this pull request Jun 3, 2024
Identify returned "token" as string.
megamanics pushed a commit to devops-testbed/openai-python that referenced this pull request Aug 14, 2024
Identify returned "token" as string.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants