Skip to content

Fix NullReferenceException thrown in CreateAddCustomHeadersPolicy when OpenAIClientOptions is null #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
trrwilson merged 2 commits into from
Jun 24, 2024
Merged

Fix NullReferenceException thrown in CreateAddCustomHeadersPolicy when OpenAIClientOptions is null #85

trrwilson merged 2 commits into from
Jun 24, 2024

Conversation

@joseharriaga
Copy link
Collaborator

@joseharriaga joseharriaga commented Jun 23, 2024

This change adds a necessary null check to the CreateAddCustomHeadersPolicy method in the OpenAIClient for the cases when the OpenAIClientOptions argument is null.

@joseharriaga joseharriaga changed the title Fix NullReferenceException thrown when OpenAIClientOptions is null Fix NullReferenceException thrown in CreateAddCustomHeadersPolicy when OpenAIClientOptions is null Jun 23, 2024
This was referenced Jun 23, 2024
Closed
Closed
@trrwilson trrwilson merged commit 0b97311 into main Jun 24, 2024
@trrwilson trrwilson deleted the joseharriaga/Null-ClientOptions branch June 24, 2024 15:56
@dependabot dependabot bot mentioned this pull request Jan 1, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@trrwilson trrwilson trrwilson approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@joseharriaga @trrwilson