Protocol models for ChatClient #778
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephentoub
reviewed
Oct 28, 2025
api/OpenAI.net8.0.cs
Outdated
| public ClientPipeline Pipeline { get; } | ||
| public virtual ClientResult<ChatCompletion> CompleteChat(params ChatMessage[] messages); | ||
| [Experimental("OPENAI001")] | ||
| public virtual ClientResult<ChatCompletionResult> CompleteChat(CreateChatCompletionOptions options, CancellationToken cancellationToken = default); |
Contributor
There was a problem hiding this comment.
Can I pass in a RequestOptions?
Collaborator
Author
There was a problem hiding this comment.
You could use the protocol method overload to do that like this:
ChatCompletionResult response = (ChatCompletionResult)await client.CompleteChatAsync(options, new RequestOptions());The CreateChatCompletionOptions would be implicitly cast to BinaryContent.
christothes
requested review from
ShivangiReja,
joseharriaga and
trrwilson
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.