Fix deserialization of run steps when using file search and mitigate .NET runtime issue when serializing ChatResponseFormat
#206
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pauluz26
approved these changes
Sep 3, 2024
Pauluz26
left a comment
Pauluz26
left a comment
There was a problem hiding this comment.
Would be great if this can be fixed, as we are running in production application problems because we use the FileSearch a lot.
Pauluz26
approved these changes
Sep 3, 2024
… serializing correct on targets including Unity.
joseharriaga
changed the title
ChatResponseFormat
trrwilson
approved these changes
Sep 3, 2024
This was referenced Sep 3, 2024
Closed
Collaborator
Author
|
@Pauluz26 This fix is now live starting with version 2.0.0-beta.11: Thank you! |
2 tasks
|
Great! I will do some testings and update our deployments! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IReadOnlyDictionary<string, string>is incorrect and causing issues during deserialization after the latest service. This fix changes this internal representation toIReadOnlyDictionary<string, BinaryData>instead.ChatResponseFormatfrom serializing correct on targets including Unity.SpeechGenerationOptions'sSpeedproperty toSpeedRatio.GeneratedSpeechFormatfrom an enum to an extensible enum.