[ModelFactory] Implemented Audio, Embedding, and Image factories #139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kinelski
commented
Jul 24, 2024
kinelski
commented
Jul 24, 2024
kinelski
commented
Jul 24, 2024
kinelski
commented
Jul 25, 2024
kinelski
commented
Jul 25, 2024
joseharriaga
reviewed
Aug 6, 2024
joseharriaga
approved these changes
Aug 9, 2024
kinelski
added a commit
to kinelski/openai-dotnet
that referenced
this pull request
Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding Model Factories for Audio, Embedding, and Image models. These factories can be used to instantiate models for mocking.
At the moment there's no way to have the factories generated automatically since they are split across multiple namespaces.
I tried to keep them as close to generated code as possible. In case we manage to have the code generator generating them automatically for us, it would be ideal if we could keep changes to a minimum when migrating from manually-written to generated code.