Make VideoRecorder backward-compatible to gym<0.23
#2678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @RedTachyon could you help review this please? |
witoong623
reviewed
Mar 29, 2022
| '`env.metadata["video.frames_per_second"] is marked as deprecated and will be replaced with `env.metadata["render_fps"]` ' | ||
| "see https://github.com/openai/gym/pull/2654 for more details" | ||
| ) | ||
| self.frames_per_sec = self.backward_compatible_frames_per_sec |
There was a problem hiding this comment.
These assignment will create a new bug if an user implements only new render_fps.
What if we use get('render_fps') so that when it is not available, it is None, and then if the user doesn't have that value, then we go back to use video.frames_per_second (which default to 30) and warn the user.
I'm happy to make PR to fix this if you want.
There was a problem hiding this comment.
@witoong623 if you could make a PR for this, that'd be great
There was a problem hiding this comment.
This was fixed in #2703
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes
VideoRecorderbackward-compatible togym<0.23. See #2675.