Env plugins, remove gym.envs.internal and replace with __internal__ key #2409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the previous PR RE: the env plugin system, I think a design choice was made which doesn't make sense.
We should specify a function to execute, NOT a module to load. Creating modules is more of a pain when we a package maintainer could specify one module with multiple functions to call.
Secondly, we should remove the
gym.envs.internalentry point and just have a special key of__internal__. This is much cleaner and doesn't require the use of an arbitrary key forgym.envs.internalthat would never be used.We also silently fail upon executing the plugin function so we don't crash Gym upon import.