Add compliance testing for API #2289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is awesome! -Please make this test be applied to all environments in Gym as part of CI tests |
tristandeleu
reviewed
Aug 4, 2021
|
@amtamasi as long as the code is attributed and you say it was under the MIT license you don't have to copy paste the entire license it into the file |
zlig
pushed a commit
to zlig/gym
that referenced
this pull request
Sep 6, 2021
* Copied over SB3 env checker * Added test from SB3 * Addition of MIT license attribution and black formatting * Removed SB3 dependence * Implemented rough, non-vectorized version of check_nan * Made some SB3 warnings a bit more "general" * Removed check for "unsupported" spaces, since Gym should support any space * Added action/observation checks from pettingzoo, referenced in file docstring * Removed copy of MIT license in file docstring * Re-added usage of the check_inf flag for helper functino * Changed test to be simple/classic example. Should add more tests * Added API compliance check to registered envs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2278