Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes fetch/slide environment. #1511

Merged
merged 2 commits into from
May 29, 2019
Merged

Fixes fetch/slide environment. #1511

merged 2 commits into from
May 29, 2019

Conversation

wojzaremba
Copy link
Contributor

No description provided.

@wojzaremba wojzaremba requested a review from pzhokhov May 28, 2019 20:19
Copy link
Collaborator

@pzhokhov pzhokhov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! This seems like a minor enough change to not create a new version of environment (i.e. FetchSlide-v2), but we can do that, if necessary. One more thing - if we are releasing this to pypi (I assume that's the purpose of bumping the version), let's add description of the change to README.md; and a git tag (that will trigger the deployment to pypi)

@wojzaremba wojzaremba merged commit ff4664b into master May 29, 2019
@wojzaremba wojzaremba deleted the woj-fixfetch branch May 29, 2019 00:53
zlig pushed a commit to zlig/gym that referenced this pull request Apr 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants