Add Smart Approvals guardian review across core, app-server, and TUI - #13860

Merged

charley-oai merged 144 commits into

mainfrom

guardian-assessment-ui

Mar 13, 2026

Commits on Mar 13, 2026

add guardian assessment thread items

charley-oai
and
codex
committed
be4812a
neutralize guardian denied history wording

charley-oai
and
codex
committed
7f753e0
simplify guardian assessment tui handling

charley-oai
and
codex
committed
374fc9c
neutralize guardian approval actor wording

charley-oai
and
codex
committed
e252426
neutralize guardian assessment wording

charley-oai
and
codex
committed
8ce553b
restore schema eof newlines

charley-oai
and
codex
committed
715abf4
document guardian assessment api as unstable

charley-oai
and
codex
committed
83a3981
fix guardian rebase fallout

charley-oai
and
codex
committed
8702529
remove dead guardian exec helper

charley-oai
and
codex
committed
94647cd
redact denied guardian action payloads

charley-oai
and
codex
committed
6fae374
fallback guardian notifications to event turn id

charley-oai
and
codex
committed
5c2b041
fix app-server guardian assessment test

charley-oai
and
codex
committed
2b25193
fix clippy in guardian assessment test

charley-oai
and
codex
committed
9a5811b
update guardian assessment generated fixtures

charley-oai
and
codex
committed
caa9c10
rename guardian feature to Smart Approvals and link menus

charley-oai
and
codex
committed
9fc97b6
hide Smart Approvals until feature is enabled

charley-oai
and
codex
committed
21f33aa
improve Smart Approvals feature description

charley-oai
and
codex
committed
ce20ae5
add approval review policy config

charley-oai
and
codex
committed
40759a3
Keep feature flag changes in experimental menu only

charley-oai
and
codex
committed
75197f9
Add history entries for Smart Approvals toggles

charley-oai
and
codex
committed
521fa2e
wire approval review policy through live overrides

charley-oai
and
codex
committed
453d15c
add approval review policy for smart approvals

charley-oai
and
codex
committed
c1799e0
hide smart approvals when feature is disabled

charley-oai
and
codex
committed
a740b6e
validate approval review policy against feature flag

charley-oai
and
codex
committed
36c4b43
fix smart approvals feature toggle persistence

charley-oai
and
codex
committed
4a9d6d7
fix exec approval review policy propagation

charley-oai
and
codex
committed
42be6bf
rename remaining app-server guardian protocol helpers

charley-oai
and
codex
committed
5884590
normalize app-server approval state into tool items

charley-oai
and
codex
committed
74d0266
clear disabled feature flags in profile scope

charley-oai
and
codex
committed
017f220
tolerate missing cwd in guardian replay

charley-oai
and
codex
committed
16de97f
remove stale guardian app-server import

charley-oai
and
codex
committed
cf0cc1b
fix feature flag lookup in config edits

charley-oai
and
codex
committed
b93b50c
fix profile-scoped smart approvals toggles

charley-oai
and
codex
committed
eaa8394
fix app-server approval status handling

charley-oai
and
codex
committed
e635215
tui: apply smart approvals feature toggles immediately
charley-oai
committed
ef7c0c5
fix apply_patch guardian clippy

charley-oai
and
codex
committed
3086756
support concurrent guardian network approvals

charley-oai
and
codex
committed
e5ab4af
default session review policy in protocol

charley-oai
and
codex
committed
e755b6c
fix rebased guardian test fallout

charley-oai
and
codex
committed
ec2829d
rename smart approvals feature key

charley-oai
and
codex
committed
3e12e2c
support string guardian command rendering

charley-oai
and
codex
committed
f237690
map guardian network actions into thread history

charley-oai
and
codex
committed
98bf6a5
collapse network approval denial branch

charley-oai
and
codex
committed
8153da9
update app-server file change approval tests

charley-oai
and
codex
committed
5799b46
clarify smart approvals alias deprecation

charley-oai
and
codex
committed
6cde3e2
migrate guardian_approval to smart_approvals

charley-oai
and
codex
committed
3a1b3a5
remove guardian_approval fallback alias

charley-oai
and
codex
committed
c0ed7e9
add app-server review policy conversions

charley-oai
and
codex
committed
3c32cf6
remove smart approvals config gate

charley-oai
and
codex
committed
2acbb28
complete approved network review items
charley-oai
committed
7022a0e
fix stale mcp guardian callsites
charley-oai
committed
9833bbb
fix stale guardian mcp test
charley-oai
committed
156f234
complete approved network review updates
charley-oai
committed
81b12f2
fix smart approvals experimental toggle behavior

charley-oai
and
codex
committed
b8387b6
finish guardian assessment followups

charley-oai
and
codex
committed
c94913e
separate guardian developer message

charley-oai
and
codex
committed
aae6063
tone down guardian review status ui

charley-oai
and
codex
committed
179ff23
sync review policy into approvals popup state

charley-oai
and
codex
committed
53f1659
clear guardian review wait after decision

charley-oai
and
codex
committed
c5fe4e8
relax smart approvals preset matching

charley-oai
and
codex
committed
4700c5f
fix stale protocol review policy tests

charley-oai
and
codex
committed
ae24a46
update smart approvals preset test

charley-oai
and
codex
committed
23f1e08
reconstruct guardian execve thread items

charley-oai
and
codex
committed
1786286
avoid string heuristics for guardian network items

charley-oai
and
codex
committed
2b63a9d
update guardian snapshot and config schema

charley-oai
and
codex
committed
3ca2d16
show parallel guardian reviews in tui

charley-oai
and
codex
committed
59964ec
minimize guardian assessment event payloads

charley-oai
and
codex
committed
e73c18c
preserve profile feature disables

charley-oai
and
codex
committed
759a079
complete denied automatic approval items

charley-oai
and
codex
committed
b966fca
ignore smart approvals flag in exec

charley-oai
and
codex
committed
aa9dc37
fix missing app-server mcp status import

charley-oai
and
codex
committed
b590097
clarify approval review policy docs

charley-oai
and
codex
committed
52192b4
replace item updated with auto review started notification

charley-oai
and
codex
committed
7a980ac
avoid forcing default review policy override

charley-oai
and
codex
committed
74a9d01
fix exec approval review policy tests

charley-oai
and
codex
committed
ebb907e
mark approval review app-server fields unstable

charley-oai
and
codex
committed
fa0aca0
fix request user input turn id fallback

charley-oai
and
codex
committed
3282efc
avoid duplicate mcp approval completions

charley-oai
and
codex
committed
a0fc25c
fix redundant clone in thread history test

charley-oai
and
codex
committed
3efaf46
route delegated exec approvals through guardian

charley-oai
and
codex
committed
ce399a3
accept snake_case review risk fields

charley-oai
and
codex
committed
51c27e4
align auto approval review protocol with item lifecycles

charley-oai
and
codex
committed
584f8ad
route delegated approvals through auto review

charley-oai
and
codex
committed
cda66a4
fix delegated auto review clippy issues

charley-oai
and
codex
committed
f078987
route delegated MCP approvals through auto review

charley-oai
and
codex
committed
2a3b67a
fix stale codex_delegate test callsite

charley-oai
and
codex
committed
3765a5d
nest auto approval review notification paths

charley-oai
and
codex
committed
fde84a9
cancel delegated guardian reviews
charley-oai
committed
03128af
remove stale guardian import

charley-oai
and
codex
committed
5c94f83
refactor thread history approval updates

charley-oai
and
codex
committed
29f2f90
emit terminal event for cancelled auto review

charley-oai
and
codex
committed
d5a650c
send manual review policy override

charley-oai
and
codex
committed
41b1809
fix stale guardian test callsites after rebase

charley-oai
and
codex
committed
dbb6f4f
gate mcp approval replay to approval prompts

charley-oai
and
codex
committed
e4f9740
fix stale smart approvals fixtures

charley-oai
and
codex
committed
b7ac269
add comment
charley-oai
committed
260c0d0
Simplify guardian approval review notifications
charley-oai
committed
37708fd
Clarify approval review policy stability
charley-oai
committed
ff6a88c
Clarify auto approval review docs
charley-oai
committed
f1e4008
Clarify guardian approval review flow

charley-oai
and
codex
committed
b511c3b
Clarify approvals reviewer documentation

charley-oai
and
codex
committed
af11872
Remove undeployed reviewer aliases

charley-oai
and
codex
committed
63e94f6
Document guardian feature alias migration

charley-oai
and
codex
committed
d2ff6e7
Remove duplicate guardian apply patch changes payload

charley-oai
and
codex
committed
b8f4d68
Refine smart approvals feature description

charley-oai
and
codex
committed
4c40b41
Preserve network review turn ids in guardian events

charley-oai
and
codex
committed
6ef07d6
Avoid reporting cancelled guardian reviews as denied

charley-oai
and
codex
committed
a297eec
Mirror guardian review events to ancestor threads

charley-oai
and
codex
committed
c2666fe
Use command item ids for guardian exec reviews

charley-oai
and
codex
committed
a157346
Render approved guardian reviews in TUI

charley-oai
and
codex
committed
5c0920f
Emit terminal aborted guardian reviews

charley-oai
and
codex
committed
751fb2b
Stabilize guardian review IDs and MCP approval strings

charley-oai
and
codex
committed
edc06b3
Revert ancestor guardian review mirroring

charley-oai
and
codex
committed
cfcf476
Include guardian action in review notifications

charley-oai
and
codex
committed
970f106
Preserve delegated MCP guardian denials

charley-oai
and
codex
committed
fe72a3a
Attach action to approved guardian events

charley-oai
and
codex
committed
24a3533
Clarify parallel exec command results

charley-oai
and
codex
committed
adffb3b
Stabilize guardian network review IDs

charley-oai
and
codex
committed
a1e9033
Clarify guardian developer prompt shaping

charley-oai
and
codex
committed
47062dc
Clarify guardian MCP decline token

charley-oai
and
codex
committed
9d091f9
Tighten guardian status footer state

charley-oai
and
codex
committed
c0c931b
Clarify pending guardian footer state

charley-oai
and
codex
committed
59b998e
Fix default permissions snapshot selection

charley-oai
and
codex
committed
42ad4da
Fix core compile regressions

charley-oai
and
codex
committed
642efe1
Document delegated MCP invocation cache

charley-oai
and
codex
committed
c23285e
Document delegated MCP guardian shim

charley-oai
and
codex
committed
0390248
Extract smart approvals preset helper

charley-oai
and
codex
committed
bf8e2a3
Fix unified exec suite parsing for command-prefixed output

charley-oai
and
codex
committed
dc6e345
Align guardian approval docs with current behavior

charley-oai
and
codex
committed
2c5e316
Clarify guardian review persistence TODO

charley-oai
and
codex
committed
64535a1
Soften smart approvals toggle comment

charley-oai
and
codex
committed
b3b08cc
Clarify smart approvals toggle flow

charley-oai
and
codex
committed
1bf30ec
Tighten guardian footer status state

charley-oai
and
codex
committed
5f8f6fd
Tighten guardian TUI state updates

charley-oai
and
codex
committed
5493472
Refine smart approvals TUI updates

charley-oai
and
codex
committed
1bfde2f
Inline guardian status helper

charley-oai
and
codex
committed
20f80c2
Document guardian assessment handling

charley-oai
and
codex
committed
7c7e157
Fix profile smart approvals disable guard

charley-oai
and
codex
committed
656a280
Drop unshipped guardian background status path

charley-oai
and
codex
committed
0e682e5
Migrate guardian alias to reviewer setting

charley-oai
and
codex
committed
5b9bb7d
Mark approvals reviewer config unstable and clean delegate flow

charley-oai
and
codex
committed
436bffb
Inline delegate approval await wrappers

charley-oai
and
codex
committed
919718b
Fix override turn context test initializers

charley-oai
and
codex
committed
f0eebb6
Fix stale core test helpers

charley-oai
and
codex
committed
22eeedf

Uh oh!

Commits

Commits on Mar 13, 2026