-
Notifications
You must be signed in to change notification settings - Fork 202
Add node 24 and 26 #101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
willwang-openai
wants to merge
1
commit into
openai:main
Choose a base branch
from
willwang-openai:willwang-add-node-24-26
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+3
−1
Open
Add node 24 and 26 #101
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -134,7 +134,7 @@ RUN apt-get update \ | |
| "$pyv/bin/pip" install --no-cache-dir --no-compile ruff black mypy pyright isort pytest; \ | ||
| done \ | ||
| && rm -rf /root/.cache/pip ~/.cache/pip ~/.cache/pipx | ||
|
|
||
| # Reduce the verbosity of uv - impacts performance of stdout buffering | ||
| ENV UV_NO_PROGRESS=1 | ||
|
|
||
|
|
@@ -159,6 +159,8 @@ RUN git -c advice.detachedHead=0 clone --branch "$NVM_VERSION" --depth 1 https:/ | |
| && nvm install 18 && nvm use 18 && npm install -g [email protected] [email protected] && corepack enable && corepack install -g yarn \ | ||
| && nvm install 20 && nvm use 20 && npm install -g [email protected] [email protected] && corepack enable && corepack install -g yarn \ | ||
| && nvm install 22 && nvm use 22 && npm install -g [email protected] [email protected] && corepack enable && corepack install -g yarn \ | ||
| && nvm install 24 && nvm use 24 && npm install -g [email protected] [email protected] && corepack enable && corepack install -g yarn \ | ||
| && nvm install 26 && nvm use 26 && npm install -g [email protected] [email protected] && corepack enable && corepack install -g yarn \ | ||
| && nvm alias default "$NODE_VERSION" \ | ||
| && nvm cache clear \ | ||
| && npm cache clean --force || true \ | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new
nvm install 26line causes the Docker build to fail.nvmcan only install versions that have been published upstream, and Node.js 26 has not been released yet (nvm responds withVersion 'v26.0.0' (with LTS) not yet released). Because this is inside a singleRUNblock, the entire image build halts. Please revert or guard this step until Node 26 actually ships.Useful? React with 👍 / 👎.