Properly diff the PR against master
#61
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So when master moves forward, the new commits on master are also included in `base...head`, which makes it look like parts of the PR are “reverting” them. When reviewing the PR, don't use the `base...head` notation (which includes all commits reachable from base or head BUT not from both). Instead, use `base..head` (commits reachable from head which are not reachable from base).
|
All contributors have signed the CLA ✍️ ✅ |
Author
|
I have read the CLA Document and I hereby sign the CLA |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug: When master moves forward, the new commits on master are also included in
base...head, which makes it look like parts of the PR are “reverting” them.Fix: When reviewing the PR, don't use the
base...headnotation (which includes all commits reachable from base or head BUT not from both). Instead, usebase..head(commits reachable from head which are not reachable from base).