Hotfix/fix incorrect property type #79
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @jonferguson , just to let you know the Models in this library are auto-generated, so these changes will be overwritten next time the models change. We'll need to fix this in the generation library, but it's odd why it's not correct in the first place |
|
Do you still need this change in? If I don't hear from you in the next couple of weeks I'll be closing this PR. |
nickevansuk
reviewed
Nov 25, 2021
| @@ -20,6 +20,7 @@ class RpdeKind | |||
| const HEADLINE_EVENT = "HeadlineEvent"; | |||
| const EVENT = "Event"; | |||
| const EVENT_SERIES = "EventSeries"; | |||
| const ON_DEMAND_EVENT = "OnDemandEvent"; | |||
There was a problem hiding this comment.
@nathansalter it might be worth keeping this one in? Agreed the rest look like a generator bug, so perhaps we create an issue for those in models-lib?
There was a problem hiding this comment.
Have created openactive/models-lib#49 in fact
There was a problem hiding this comment.
Have broken out this fix into #86
|
So this is now resolved by: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.