wpa_supplicant: Fix crash on unexpected restarts of wpa_supplicant #931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtomaschewski
requested changes
Oct 5, 2022
There was a problem hiding this comment.
LGTM, but please fix indenting in the commit message:
commit 3309697d1dd9eee6470a04c63f84e630695810e9
Author: Clemens Famulla-Conrad <[email protected]>
Date: Thu Jul 7 22:18:08 2022 +0200
wpa-supplicant: Add refcounting for ni_wpa_bss_t
Each call on DBus can result in async receving of DBus signals. Thus we need to protect our current working object, that it do not get removed because of such a signal.
Each call on DBus can result in async receving of DBus signals. Thus we need to protect our current working object, that it do not get removed because of such a signal. Signed-off-by: Clemens Famulla-Conrad <[email protected]>
Each call on DBus can result in async receving of DBus signals. Thus we need to protect our current working object, that it do not get removed because of such a signal.
If the wpa_supplicant restart (e.g. segfault), the restart handler cleanup all internal data structures associated to this wpa_supplicant instance. With this, the ni_wpa_wif_t->client is set to NULL and we need to cover this stage in each translate error call.
cfconrad
force-pushed
the
wireless_fix_wpa_supplicant_restart
branch
from
9f18241
to
d7ee347
Compare
|
Changed the commit message and rebased on top of master. |
Merged
mtomaschewski
added a commit
that referenced
this pull request
Oct 20, 2022
- version 0.6.70 - build: Link as Position Independent Executable (bsc#1184124) - dhcp4: Fix issues in reuse of last lease (bsc#1187655) - dhcp6: Add option to refresh lease (jsc#SLE-9492,jsc#SLE-24307) - dhcp6: Remove address before release (USGv6 DHCPv6_1_2_07b) - dhcp6: Ignore lease release status (USGv6 DHCPv6_1_2_07e,1_3_03) - dhcp6: Consider ppp interfaces supported (gh##924) - team: Fix to configure port priority in teamd (bsc#1200505) - firewall-ext: No config change on ifdown (bsc#1201053,bsc#118950) - wireless: Fix SEGV on supplicant restart (gh##931) - wireless: Add support for WPA3 and PMF (bsc#1198894) - wireless: Remove libiw dependencies (gh##910) - client: Fix SEGV on empty xpath results (gh##919) - client: Add release options to ifdown/ifreload (jsc#SLE-10249) - dbus: Clear string array before append (gh##913) - socket: Fix SEGV on heavy socket restart errors (bsc#1192508) - systemd: Remove systemd-udev-settle dependency (bsc#1186787)
bmwiedemann
pushed a commit
to bmwiedemann/openSUSE
that referenced
this pull request
Oct 22, 2022
https://build.opensuse.org/request/show/1030243 by user wicked-maintainers + dimstar_suse - changes: spell fixes - version 0.6.70 - build: Link as Position Independent Executable (bsc#1184124) - dhcp4: Fix issues in reuse of last lease (bsc#1187655) - dhcp6: Add option to refresh lease (jsc#SLE-9492,jsc#SLE-24307) - dhcp6: Remove address before release (USGv6 DHCPv6_1_2_07b) - dhcp6: Ignore lease release status (USGv6 DHCPv6_1_2_07e,1_3_03) - dhcp6: Consider ppp interfaces supported (gh#openSUSE/wicked#924) - team: Fix to configure port priority in teamd (bsc#1200505) - firewall-ext: No config change on ifdown (bsc#1201053,bsc#118950) - wireless: Fix SEGV on supplicant restart (gh#openSUSE/wicked#931) - wireless: Add support for WPA3 and PMF (bsc#1198894) - wireless: Remove libiw dependencies (gh#openSUSE/wicked#910) - client: Fix SEGV on empty xpath results (gh#openSUSE/wicked#
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once wpa_supplicant restart unexpected, wickedd tend to crash, if the wpa_supplicant handler code was currently in one of the
DBus calls. To fix this, we need refcounting for the DBus objects of wpa_supplicant and be aware of such a situation in error handing.