Refactor makeurl(), deprecate query taking string or list arguments, drop osc_urlencode()

[dmach]

No description provided.

[pep8speaks]

Hello @dmach! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

• In the file osc/core.py:

Line 7879:27: E203 whitespace before ','

• In the file tests/test_core.py:

Line 58:121: E501 line too long (128 > 120 characters)

• In the file tests/test_update.py:

Line 196:121: E501 line too long (124 > 120 characters)
Line 197:121: E501 line too long (124 > 120 characters)

Comment last updated at 2024-02-09 12:26:54 UTC

[codecov]

Codecov Report

Attention: 54 lines in your changes are missing coverage. Please review.

Comparison is base (4240305) 31.46% compared to head (0f8a843) 31.51%.
Report is 13 commits behind head on master.

Files	Patch %	Lines
osc/core.py	51.94%	37 Missing ⚠️
osc/commandline.py	12.50%	7 Missing ⚠️
osc/fetch.py	0.00%	4 Missing ⚠️
osc/meter.py	86.20%	4 Missing ⚠️
osc/build.py	33.33%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1476      +/-   ##
==========================================
+ Coverage   31.46%   31.51%   +0.04%     
==========================================
  Files          49       50       +1     
  Lines       17884    17908      +24     
==========================================
+ Hits         5628     5643      +15     
- Misses      12256    12265       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[dmach]

The failing features/undelete.feature behave test is expected.

[dcermak]

LGTM, I've added a few stylistic comments/nitpicks, but sadly I cannot estimate whether this will not break anything…