Add state acceptable_by_lawyer #3151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lkocman
force-pushed
the
acceptable_by_lawyer
branch
2 times, most recently
from
57806a3
to
846574e
Compare
|
Quite a few implementation details of the LegalDB database schema are currently leaking into the legal-auto code. Which means even small changes can have very unintended consequences. It would be very helpful to have someone to discuss with how we can improve the situation in the future. |
kraih
approved these changes
Aug 30, 2024
bugfinder
approved these changes
Aug 30, 2024
lkocman
force-pushed
the
acceptable_by_lawyer
branch
from
846574e
to
ff6321b
Compare
|
Thanks, looks like it works. https://legaldb.suse.de/reviews/details/412946 -> https://build.suse.de/request/show/343414 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to Issue #3149
States are documented here https://github.com/openSUSE/cavil/blob/master/docs/Architecture.md#states
"accetpable" is reviewed by an expert, "acceptable_by_lawyer" reviewed by an actual lawyer
This new state gives us opportnity to handle situation differently in case that review is done by lawyer, vs best effort.