Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check devel pkg maintainers in devel_project_review_needed #3135

Merged
merged 1 commit into from
Aug 20, 2024

Conversation

Vogtinator
Copy link
Member

If a devel pkg maintainer submits, don't add a review on the devel pkg. Without this change it only looked at the /search/owner result which doesn't always work.

Example: https://build.opensuse.org/request/show/1193836

Previously:

> ./check_source.py --dry --debug --osc-debug --verbose id 1193836
DEBUG: makeurl: /request/1193836?withfullhistory=1
[D] Starting new HTTPS connection (1): api.opensuse.org:443
[D] https://api.opensuse.org:None "GET /request/1193836?withfullhistory=1 HTTP/1.1" 401 503
[D] Starting new HTTPS connection (2): api.opensuse.org:443
[D] https://api.opensuse.org:None "GET /request/1193836?withfullhistory=1 HTTP/1.1" 200 None
[I] checking 1193836
DEBUG: makeurl: /search/project?match=starts-with%28remoteurl%2C+%22http%22%29
[D] https://api.opensuse.org:None "GET /search/project?match=starts-with%28remoteurl%2C+%22http%22%29 HTTP/1.1" 200 None
DEBUG: makeurl: /source/openSUSE:Factory/_attribute/OSRT:Config?
[D] https://api.opensuse.org:None "GET /source/openSUSE:Factory/_attribute/OSRT:Config HTTP/1.1" 200 None
DEBUG: makeurl: /group/factory-staging?
[D] https://api.opensuse.org:None "GET /group/factory-staging HTTP/1.1" 200 None
DEBUG: makeurl: /comments/request/1193836?
[D] https://api.opensuse.org:None "GET /comments/request/1193836 HTTP/1.1" 200 None
DEBUG: makeurl: /source/openSUSE:Factory?view=info&package=opensuse-postfix-image&nofilename=1
[D] https://api.opensuse.org:None "GET /source/openSUSE:Factory?view=info&package=opensuse-postfix-image&nofilename=1 HTTP/1.1" 200 190
[D] https://api.opensuse.org:None "GET /search/request?match=state/@name='new'+and+(action/target/@project='openSUSE:Factory'+and+action/target/@package='opensuse-postfix-image')+and+(action/@type='delete'+or+action/@type='submit') HTTP/1.1" 200 None
DEBUG: makeurl: /search/owner?binary=opensuse-postfix-image&project=openSUSE%3AFactory
[D] https://api.opensuse.org:None "GET /search/owner?binary=opensuse-postfix-image&project=openSUSE%3AFactory HTTP/1.1" 200 None
DEBUG: makeurl: /search/owner?binary=opensuse-postfix-image
[D] https://api.opensuse.org:None "GET /search/owner?binary=opensuse-postfix-image HTTP/1.1" 200 None
DEBUG: makeurl: /source/openSUSE:Factory/opensuse-postfix-image/_meta?
[D] https://api.opensuse.org:None "GET /source/openSUSE:Factory/opensuse-postfix-image/_meta HTTP/1.1" 200 None
[D] skipped adding duplicate review for devel:kubic:containers/opensuse-postfix-image
DEBUG: makeurl: /request/1193836?
[D] https://api.opensuse.org:None "GET /request/1193836 HTTP/1.1" 200 None
[I] 1193836 accepted: ok
[D] 1193836 review not changed

Now:

> ./check_source.py --dry --debug --osc-debug --verbose id 1193836
DEBUG: makeurl: /request/1193836?withfullhistory=1
[D] Starting new HTTPS connection (1): api.opensuse.org:443
[D] https://api.opensuse.org:None "GET /request/1193836?withfullhistory=1 HTTP/1.1" 200 None
[I] checking 1193836
DEBUG: makeurl: /search/project?match=starts-with%28remoteurl%2C+%22http%22%29
[D] https://api.opensuse.org:None "GET /search/project?match=starts-with%28remoteurl%2C+%22http%22%29 HTTP/1.1" 200 None
DEBUG: makeurl: /source/openSUSE:Factory/_attribute/OSRT:Config?
[D] https://api.opensuse.org:None "GET /source/openSUSE:Factory/_attribute/OSRT:Config HTTP/1.1" 200 None
DEBUG: makeurl: /group/factory-staging?
[D] https://api.opensuse.org:None "GET /group/factory-staging HTTP/1.1" 200 None
DEBUG: makeurl: /comments/request/1193836?
[D] https://api.opensuse.org:None "GET /comments/request/1193836 HTTP/1.1" 200 None
DEBUG: makeurl: /source/openSUSE:Factory?view=info&package=opensuse-postfix-image&nofilename=1
[D] https://api.opensuse.org:None "GET /source/openSUSE:Factory?view=info&package=opensuse-postfix-image&nofilename=1 HTTP/1.1" 200 190
[D] https://api.opensuse.org:None "GET /search/request?match=state/@name='new'+and+(action/target/@project='openSUSE:Factory'+and+action/target/@package='opensuse-postfix-image')+and+(action/@type='delete'+or+action/@type='submit') HTTP/1.1" 200 None
DEBUG: makeurl: /search/owner?binary=opensuse-postfix-image&project=openSUSE%3AFactory
[D] https://api.opensuse.org:None "GET /search/owner?binary=opensuse-postfix-image&project=openSUSE%3AFactory HTTP/1.1" 200 None
DEBUG: makeurl: /search/owner?binary=opensuse-postfix-image
[D] https://api.opensuse.org:None "GET /search/owner?binary=opensuse-postfix-image HTTP/1.1" 200 None
DEBUG: makeurl: /source/openSUSE:Factory/opensuse-postfix-image/_meta?
[D] https://api.opensuse.org:None "GET /source/openSUSE:Factory/opensuse-postfix-image/_meta HTTP/1.1" 200 None
DEBUG: makeurl: /source/devel:kubic:containers/opensuse-postfix-image/_meta?
[D] https://api.opensuse.org:None "GET /source/devel:kubic:containers/opensuse-postfix-image/_meta HTTP/1.1" 200 None
DEBUG: makeurl: /source/devel:kubic:containers/_meta?
[D] https://api.opensuse.org:None "GET /source/devel:kubic:containers/_meta HTTP/1.1" 200 None
DEBUG: makeurl: /group/factory-maintainers?
[D] https://api.opensuse.org:None "GET /group/factory-maintainers HTTP/1.1" 200 None
[D] devel project review not needed
DEBUG: makeurl: /request/1193836?
[D] https://api.opensuse.org:None "GET /request/1193836 HTTP/1.1" 200 None
[I] 1193836 accepted: ok
[D] 1193836 review not changed

@Vogtinator
Copy link
Member Author

Related to #3041 (comment)

@Vogtinator Vogtinator force-pushed the no_duplicate_devel branch 4 times, most recently from d772592 to 78f90d6 Compare August 19, 2024 12:53
If a devel pkg maintainer submits, don't add a review on the devel pkg.
Without this change it only looked at the /search/owner result which
doesn't always work.
@Vogtinator Vogtinator merged commit 6d79e25 into openSUSE:master Aug 20, 2024
11 checks passed
@Vogtinator Vogtinator deleted the no_duplicate_devel branch August 20, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant