SLSA support #3058
Merged
SLSA support #3058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add script to run relpkg - Add systemd service and timer - Change SLSA user - Only run pkglistgen when build finishes
- Add oscrc file for SLSA - Change user to osrt-slsa
- Refactor log - Unify log for pkglistgen - Replace external while true loop with a systemd timer for pkglistgen - Add process check on verify-build-and-generatelists and generate-release-packages to avoid start pkglistgen when there is an instance that is already running it - SLSA services must not share the same workdir
- Decrease the interval time to trigger pkglistgen - Add debug flag for relpkgen
- Create custom-cache-tag for pkglistgen to enable separate cache dir name in case of parallel running - Add custom-cache-tag to SLSA services - Check for systemd service instead of process to ensure that SLSA services will not run in parallel - Change pkglisgen timer to avoid overlap with relpkggen timer
and remove logrotate file
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #3058 +/- ##
==========================================
- Coverage 28.31% 25.37% -2.95%
==========================================
Files 86 86
Lines 14799 14803 +4
==========================================
- Hits 4191 3756 -435
- Misses 10608 11047 +439 ☔ View full report in Codecov by Sentry. |
|
the test is failed. |
SLSA scripts don't have a help flag due to they are intended to be executed by sytemd services only.
Fixed, excluded the 2 SLSA scripts from the test as they don't have help flag because they are intended to be executed only by systemd services. |
|
somebody forgot about RPM 4.19: either the user is generated properly using sysusers.d or it is at least advertised in the pkg meta |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to SLSA constrains pkglistgen.py cannot run on botmaster using gocd, as it must run on a separate and isolated server the following changes were added: