Don't abort if weakremover.inc don't exist on source project #3049
Conversation
There was a problem hiding this comment.
IMO this needs explicit error handling for all possible cases:
(exists in staging, doesn't exist in staging) * (exists in target project, doesn't exist in target project)
In the case that there's a mismatch I'm not sure what it should do though. IMO abort and ask the user to resolve it manually.
Currently it silently ignores any possible errors which is bad.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3049 +/- ##
==========================================
+ Coverage 27.99% 28.02% +0.03%
==========================================
Files 86 86
Lines 14972 14981 +9
==========================================
+ Hits 4191 4199 +8
- Misses 10781 10782 +1 ☔ View full report in Codecov by Sentry. |
For ALP, weakremover.inc might not be part of the staging parent project. Just ignore 404 error in that case.
…ng and parent projects.
Co-authored-by: Fabian Vogt <[email protected]>
The summary dictionary used to create summary-{scope}.txt was
previously returned by solve_project() via write_all_groups().
After c46dd3e, solve_project()
doesn't return anything anymore, as write_all_groups() is being
invoked just after solve_project().
Thus, the "summary" dictionary would always be None.
Since the summary dict creation is generic enough, move it
to its own function, and call it afterwards after project
solving.
This commit also drops the return statement both on write_all_groups()
and write_productcompose() (where it would always return an empty
dictionary), and moves the write_productcompose() call after
solve_project() as well to match the change with write_all_groups().
Signed-off-by: Eugenio Paolantonio <[email protected]>
|
I'd merge, but now there are unrelated commits on top |
let me fix that, I should have used a topic branch in the first place.. |
|
switching to #3083 |
For ALP, weakremover.inc might not be part of the staging parent project. Just ignore 404 error in that case.