factory-package-news: support newer python3 rpm bindings #3002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rpm's python bindings changed in version 4.15 [0] so that they actually return utf-8 strings. Handle this case while keeping support for the older bindings such as the ones shipped with Leap 15. [0] rpm-software-management/rpm@84920f8 Signed-off-by: Eugenio Paolantonio <[email protected]>
|
v2: addressed flake8 warnings :) |
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #3002 +/- ##
=======================================
Coverage 28.45% 28.45%
=======================================
Files 85 85
Lines 14716 14716
=======================================
Hits 4188 4188
Misses 10528 10528 ☔ View full report in Codecov by Sentry. |
dirkmueller
reviewed
Aug 4, 2023
| # keep this script working there too. | ||
| # | ||
| # [0] https://github.com/rpm-software-management/rpm/commit/84920f898315d09a57a3f1067433eaeb7de5e830 | ||
| def forcestr(content): |
There was a problem hiding this comment.
I wonder if utf8str would be a slightly besser name.
There was a problem hiding this comment.
Thanks, yeah definitely looks better than forcestr :) Should I make another PR that changes that?
|
test are passing, we can solve the nit anytime.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rpm's python bindings changed in version 4.15 [0] so that they actually return utf-8 strings. Handle this case while keeping support for the older bindings such as the ones shipped with Leap 15.
[0] rpm-software-management/rpm@84920f8