Add test for publish_distro #2989
Conversation
|
I'm wondering to which extent tests on this level actually work in practice. If the design and mechanisms are changed like #2954, then this might not be the case... |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2989 +/- ##
=========================================
Coverage ? 28.45%
=========================================
Files ? 85
Lines ? 14698
Branches ? 0
=========================================
Hits ? 4183
Misses ? 10515
Partials ? 0 ☔ View full report in Codecov by Sentry. |
My understanding that it is OK if tests sometimes don't cover everything. |
t/02-publish_distro_leap.sh.log
Outdated
| @@ -24,4 +24,3 @@ rsync -avvhiH t/tmp/ftp-stage/pub/opensuse//distribution/leap/15.5/repo --link-d | |||
| rsync -avhiH t/tmp/ftp-stage/pub/opensuse/source//distribution/leap/15.5/ --link-dest=t/tmp/ftp-stage/pub/opensuse/source//distribution/leap/15.5 t/tmp/ftp/pub/opensuse/source//distribution/leap/15.5 --delete-after | |||
| rsync -avhiH t/tmp/ftp-stage/pub/opensuse/debug//distribution/leap/15.5/ --link-dest=t/tmp/ftp-stage/pub/opensuse/debug//distribution/leap/15.5 t/tmp/ftp/pub/opensuse/debug//distribution/leap/15.5 --delete-after | |||
| curl -X POST -F version=111.11 https://openqa.opensuse.org/snapshot-changes/opensuse/15.5/current | |||
| stage/pub/opensuse/debug//distribution/leap/15.5 t/tmp/ftp/pub/opensuse/debug//distribution/leap/15.5 --delete-after | |||
There was a problem hiding this comment.
I have no idea why that line is truncated like this, but it has gone when stdout was replaced with stderr for logs when --dry flag is set
|
I mean I'm supportive of any test coverage, however, ... I was hoping we'd eventually replace what we have :-) |
I am investigating how to improve publish_distro script, so having some kind of tests with debug output will help to track what exactly changes.