Cleanups for accepting scm-staging bot submissions #2980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
dirkmueller
commented
Jun 28, 2023
dirkmueller
commented
- Ignore .gitattributes in checkout
- Skip Name: check when it is a scm-staging bot submission (relies on build service API that is broken for git packages)
- Skip devel-group-maintainer check
Vogtinator
reviewed
Jun 28, 2023
dirkmueller
force-pushed
the
bot_fixups
branch
4 times, most recently
from
1a6929f
to
a8a9d98
Compare
Vogtinator
reviewed
Jun 29, 2023
* Ignore .gitattributes in checkout * Skip Name: check when it is a scm-staging bot submission (relies on build service API that is broken for git packages) * Skip devel-group-maintainer check
Vogtinator
reviewed
Jun 29, 2023
| self.review_messages['declined'] = "A package submitted as %s has to build as 'Name: %s' - found Name '%s'" % ( | ||
| target_package, expected_name, new_info['name']) | ||
| return False | ||
| # TODO(dmllr): self.package_source_parse cannot handle scm_sync submissions, so skip the check for now |
Vogtinator
approved these changes
Jun 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.