Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashboard:fix openQA links #2400

Merged
merged 2 commits into from
Feb 3, 2020
Merged

Conversation

ggardet
Copy link
Member

@ggardet ggardet commented Feb 2, 2020

Tested locally.

@coveralls
Copy link

coveralls commented Feb 2, 2020

Pull Request Test Coverage Report for Build 5888

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 23.325%

Totals Coverage Status
Change from base Build 5883: 0.0%
Covered Lines: 3464
Relevant Lines: 14851

💛 - Coveralls

@coolo
Copy link
Member

coolo commented Feb 3, 2020

Did you test it by now?

@ggardet
Copy link
Member Author

ggardet commented Feb 3, 2020

Did you test it by now?

No, python3 dashboard/generate.py fails with:

Traceback (most recent call last):
  File "dashboard/generate.py", line 14, in <module>
    from osclib.conf import Config
ModuleNotFoundError: No module named 'osclib'

And missing lib is not in TW.

@coolo
Copy link
Member

coolo commented Feb 3, 2020

PYTHONPATH=. python3 dashboard/generate.py - in doubt you can check in gocd config how our tools are called :)

@coolo
Copy link
Member

coolo commented Feb 3, 2020

BTW: the package is called osclib - it lacks the python3 prefix for some reason

@coolo
Copy link
Member

coolo commented Feb 3, 2020

(most likely because it's installed in /usr/share/openSUSE-release-tools/osclib)

@ggardet
Copy link
Member Author

ggardet commented Feb 3, 2020

PYTHONPATH=. python3 dashboard/generate.py - in doubt you can check in gocd config how our tools are called :)

Ok, thanks.
I tested my latest patches and it does work properly.

@coolo coolo merged commit 8d42156 into openSUSE:master Feb 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants