commentapi: provide truncate() and apply during add_comment() (and use in repo_checker). #1089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jberry-suse
force-pushed
the
commentapi-truncate
branch
from
c8ee7dc
to
8dfc27d
Compare
This was referenced Aug 23, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
c8ee7dc:
repo_checker: package_comments(): drop truncation in favor of commentapi.
b8dc98a:
commentapi: provide truncate() and apply during add_comment().
Current limit from openSUSE/open-build-service#3584, but should likely be lower due to serialization in openSUSE/open-build-service#3638.
Fixes #1061. All comments will now automatically be truncated while handling preformatted text and not breaking tags or leaving unbalanced tags.