Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check_source: utilize project config to allow for remote entries. #1014

Merged

Conversation

jberry-suse
Copy link
Contributor

  • 0ec6d70:
    check_source: utilize project config to allow for remote entries.

    Rather than updating a local whitelist file for temporary devel project
    whitelist entries it makes more sense to allow for remote configuration.

  • 03c46f1:
    ReviewBot: provide staging_api() from repo_checker.

Seems like this is a bit more practical than having PRs to add temporary entries. Instead just add them to remote config.

devel-whitelist = project1 some:other:project project3000

If accepted, wiki should be updated to indicate a ping in IRC unless we want to accept SRs to dashboard container. :)

@jberry-suse jberry-suse changed the title Source check remote whitelist check_source: utilize project config to allow for remote entries. Jul 18, 2017
@jberry-suse jberry-suse force-pushed the source_check-remote-whitelist branch from 0ec6d70 to 6e80472 Compare July 18, 2017 22:11
@openSUSE openSUSE deleted a comment from coveralls Jul 19, 2017
@jberry-suse
Copy link
Contributor Author

I went ahead and checked the existing projects in whitelist:

devel:languages:D
hardware:sdr
isv:ownCloud:desktop
network:cluster:ohpc
network:mail:zarafa
Novell:NTS
network:messaging:matrix
security:tls
server:messaging
server:php:extensions:php7
system:snappy
X11:Solus
devel:openQA:tested

Of those the following are still not devel projects:

isv:ownCloud:desktop (last updated 1 year ago, newer subprojects)
network:mail:zarafa (no longer exists)
Novell:NTS (last updated 3 years ago)
network:messaging:matrix (last updated 9 days)
server:messaging (last updated 7 days ago)
system:snappy (last updated 2 months ago)
X11:Solus (last updated 24 days ago)

I placed all except network:mail:zarafa in the remote config so they will continue to be whitelisted post this change. Feel free to further prune the list.

Rather than updating a local whitelist file for temporary devel project
whitelist entries it makes more sense to allow for remote configuration.
It seems osc.core and similar generate both quoted and unquoted URLs that
are cached separately. Additionally, urlopen() handles quoted paths
differently from os.path.*() methods which can create issues for quoted
projects.
@jberry-suse jberry-suse force-pushed the source_check-remote-whitelist branch from 6e80472 to 5b6ad33 Compare July 19, 2017 04:52
@openSUSE openSUSE deleted a comment from coveralls Jul 19, 2017
@coveralls
Copy link

Coverage Status

Coverage increased (+0.06%) to 48.498% when pulling 5b6ad33 on jberry-suse:source_check-remote-whitelist into ce00330 on openSUSE:master.

@DimStar77
Copy link
Contributor

works for me (actually we had this in the past) - make sure to update the doc at https://en.opensuse.org/openSUSE:How_to_contribute_to_Factory#How_to_request_a_new_devel_project then though, so we can point contributors at the right way to get a new devel prj on the whitelist

@jberry-suse
Copy link
Contributor Author

@DimStar77 as in a file in dashboard container? Was it intentionally changed or side-effect of some bot change?

@jberry-suse
Copy link
Contributor Author

Also where exactly? The oldest white-list I find is 89b122d#diff-8f33b35196c4caa105bb6675c869a2a4R219 (6 years ago) and it appears to be introducing the concept and not switching from some other source.

@DimStar77
Copy link
Contributor

Also where exactly?

Actually, I was wrong - this was embedded into the .py file directly - and later split at least in an own file... so it's just logical to move it into the Staging/dashboard container now

@jberry-suse
Copy link
Contributor Author

Yeah, I split it when I rewrote bot based on ReviewBot. Ok, just making sure there was not a reason for wanted it local.

@jberry-suse jberry-suse merged commit 00c88d1 into openSUSE:master Jul 19, 2017
@DimStar77
Copy link
Contributor

works for me (actually we had this in the past) - make sure to update the doc at https://en.opensuse.org/openSUSE:How_to_contribute_to_Factory#How_to_request_a_new_devel_project then though, so we can point contributors at the right way to get a new devel prj on the whitelist

That part is missing; we currently don't tell our users how 'to do it right'

@jberry-suse
Copy link
Contributor Author

Indeed. Made the relevant changes https://en.opensuse.org/index.php?title=openSUSE%3AHow_to_contribute_to_Factory&type=revision&diff=120672&oldid=119010. Although packagelists has not yet been updated.

@jberry-suse jberry-suse deleted the source_check-remote-whitelist branch July 27, 2017 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants