-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
check_source: utilize project config to allow for remote entries. #1014
check_source: utilize project config to allow for remote entries. #1014
Conversation
0ec6d70
to
6e80472
Compare
I went ahead and checked the existing projects in whitelist:
Of those the following are still not devel projects:
I placed all except |
Rather than updating a local whitelist file for temporary devel project whitelist entries it makes more sense to allow for remote configuration.
It seems osc.core and similar generate both quoted and unquoted URLs that are cached separately. Additionally, urlopen() handles quoted paths differently from os.path.*() methods which can create issues for quoted projects.
6e80472
to
5b6ad33
Compare
works for me (actually we had this in the past) - make sure to update the doc at https://en.opensuse.org/openSUSE:How_to_contribute_to_Factory#How_to_request_a_new_devel_project then though, so we can point contributors at the right way to get a new devel prj on the whitelist |
@DimStar77 as in a file in dashboard container? Was it intentionally changed or side-effect of some bot change? |
Also where exactly? The oldest white-list I find is 89b122d#diff-8f33b35196c4caa105bb6675c869a2a4R219 (6 years ago) and it appears to be introducing the concept and not switching from some other source. |
Actually, I was wrong - this was embedded into the .py file directly - and later split at least in an own file... so it's just logical to move it into the Staging/dashboard container now |
Yeah, I split it when I rewrote bot based on ReviewBot. Ok, just making sure there was not a reason for wanted it local. |
That part is missing; we currently don't tell our users how 'to do it right' |
Indeed. Made the relevant changes https://en.opensuse.org/index.php?title=openSUSE%3AHow_to_contribute_to_Factory&type=revision&diff=120672&oldid=119010. Although packagelists has not yet been updated. |
0ec6d70:
check_source: utilize project config to allow for remote entries.
Rather than updating a local whitelist file for temporary devel project
whitelist entries it makes more sense to allow for remote configuration.
03c46f1:
ReviewBot: provide staging_api() from repo_checker.
Seems like this is a bit more practical than having PRs to add temporary entries. Instead just add them to remote config.
If accepted, wiki should be updated to indicate a ping in IRC unless we want to accept SRs to dashboard container. :)