Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduces token operations on project #15261

Merged

Conversation

hennevogel
Copy link
Member

@hennevogel hennevogel commented Nov 23, 2023

There are two types of trigger routes:

On /trigger you can trigger an type of Token except Token::Workflow
On /trigger/[rebuild, release, runservice, workflow] you can trigger only this type of Token

If a Token has a Package the operation is executed on this Package.

If a Token does not have a Package you can set one via the project/package
parameters and the operation is executed on this Package.

If a Token::Rebuild or a Token::Release has no Package you can set a
Project via the project parameter and the operation is executed on this
Project.

API Docu: https://obs-reviewlab.opensuse.org/hennevogel-featuretoken_operations_on_project/apidocs/index.html#/Trigger/post_trigger

@github-actions github-actions bot added Documentation 📖 Things regarding our documentation Frontend Things related to the OBS RoR app Test Suite / CI 💉 Things related to our tests/CI labels Nov 23, 2023
@hennevogel hennevogel marked this pull request as draft November 24, 2023 16:38
@hennevogel hennevogel force-pushed the feature/token_operations_on_project branch 3 times, most recently from d7d07e1 to 47d61cc Compare November 24, 2023 17:00
@hennevogel hennevogel force-pushed the feature/token_operations_on_project branch from 47d61cc to 45d4647 Compare December 4, 2023 14:39
@hennevogel hennevogel marked this pull request as ready for review December 4, 2023 14:39
@hennevogel hennevogel force-pushed the feature/token_operations_on_project branch 2 times, most recently from c47270a to f2a4684 Compare December 6, 2023 15:23
@hennevogel hennevogel added the review-app Apply this label if you want a review app started label Dec 6, 2023
@obs-bot
Copy link
Collaborator

obs-bot commented Dec 6, 2023

Copy link

codecov bot commented Dec 6, 2023

Codecov Report

Merging #15261 (8b874ef) into master (1f6daef) will increase coverage by 0.00%.
Report is 7 commits behind head on master.
The diff coverage is 93.02%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #15261   +/-   ##
=======================================
  Coverage   86.24%   86.25%           
=======================================
  Files         786      786           
  Lines       25744    25766   +22     
=======================================
+ Hits        22204    22224   +20     
- Misses       3540     3542    +2     

@hennevogel hennevogel force-pushed the feature/token_operations_on_project branch 2 times, most recently from dd4b6bc to 4348319 Compare December 6, 2023 16:14
@hennevogel hennevogel force-pushed the feature/token_operations_on_project branch from 4348319 to c762f1d Compare December 18, 2023 14:49
hennevogel and others added 3 commits December 18, 2023 15:50
There are two types of trigger routes:

On /trigger you can trigger an type of `Token`
On /trigger/[rebuild, release, runservice, workflow] you can trigger only this type of `Token`

If a `Token` has a `Package` the operation is executed on this `Package`.

If a `Token` does not have a `Package` you can set one via the project/package
parameters and the operation is executed on this `Package`.

If a `Token::Rebuild` or a `Token::Release` has no `Package` you can set a
`Project` via the project parameter and the operation is executed on this
`Project`.

Co-authored-by: Adrian Schröter <[email protected]>
Co-authored-by: Eduardo Navarro <[email protected]>
Drop the minitest test

Co-authored-by: Eduardo Navarro <[email protected]>
Co-authored-by: Eduardo Navarro <[email protected]>
@hennevogel hennevogel force-pushed the feature/token_operations_on_project branch from c762f1d to 8b874ef Compare December 18, 2023 14:53
@danidoni danidoni merged commit 84f525c into openSUSE:master Dec 21, 2023
20 checks passed
This was referenced Dec 21, 2023
@hennevogel hennevogel deleted the feature/token_operations_on_project branch June 27, 2024 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation 📖 Things regarding our documentation Frontend Things related to the OBS RoR app review-app Apply this label if you want a review app started Test Suite / CI 💉 Things related to our tests/CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants