Skip to content

Two little fixes for scientific defaults #1914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
franzpoeschel merged 1 commit into from
Jul 9, 2026
Merged

Two little fixes for scientific defaults #1914

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/Mesh.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -279,7 +279,8 @@ void Mesh::scientificDefaults_impl(
return auxiliary::createDefaultVector(dimensionality, 1.);
},
&Mesh::setGridUnitSIPerDimension)
.withReader(int_types, require_type<std::vector<double>>())(wor);
.withReader(numerical_types, require_type<std::vector<double>>())(
wor);
}
else
{
Expand Down
2 changes: 1 addition & 1 deletion src/backend/scientific_defaults/ConfigAttribute.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ void ConfigAttribute::read()
write_to_stderr(attribute) << "'. Expected one of ";
auxiliary::write_vec_to_stream(
std::cerr, type_unmatched.expectedDatatypes)
<< " or convertible to such a type." << std::endl;

@franzpoeschel franzpoeschel Jul 9, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Matches at this point are precise. Datatype conversions may optionally occur in later postprocessing (see require_type inside ProcessParsedAttribute.hpp).

<< "." << std::endl;
},
[&](error::ReadError const &err) {
std::cerr << "Unexpected error while trying to read "
Expand Down
Loading