Skip to content

ADIOS2: Forbid slashes in attribute and variable names #1884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
franzpoeschel merged 1 commit into from
Jun 3, 2026
Merged

ADIOS2: Forbid slashes in attribute and variable names #1884

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions src/IO/ADIOS/ADIOS2IOHandler.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -848,6 +848,14 @@ void ADIOS2IOHandlerImpl::createDataset(
{
/* Sanitize name */
std::string name = auxiliary::removeSlashes(parameters.name);
if (auxiliary::contains(name, '/'))
{
throw error::OperationUnsupportedInBackend(
"ADIOS2",
"Slashes `/` are reserved characters in the ADIOS2 backend and "
"forbidden in dataset names (name: '" +
name + "')");
}

auto const file =
refreshFileFromParent(writable, /* preferParentFile = */ true);
Expand Down Expand Up @@ -2306,6 +2314,15 @@ namespace detail
auto pos = impl->setAndGetFilePosition(writable);
auto file = impl->refreshFileFromParent(
writable, /* preferParentFile = */ false);
auto name = auxiliary::removeSlashes(parameters.name);
if (auxiliary::contains(name, '/'))
{
throw error::OperationUnsupportedInBackend(
"ADIOS2",
"Slashes `/` are reserved characters in the ADIOS2 backend and "
"forbidden in attribute names (name: '" +
name + "')");
}
auto fullName = impl->nameOfAttribute(writable, parameters.name);

auto &filedata = impl->getFileData(
Expand Down
Loading