Write scientific defaults upon close (Iteration::close or Series::close) - #1834
Merged
Conversation
Comment on lines
+281
to
+284
| // for (size_t i = 0; i < udims.size(); ++i) | ||
| // { | ||
| // res[7 * i] = 1; | ||
| // } |
Check notice
Code scanning / CodeQL
Commented-out code Note
Comment on lines
+698
to
+701
| // TODO: unitSI | ||
| // REQUIRE(r["x"].numAttributes() == 0); | ||
| // REQUIRE(r["y"].numAttributes() == 0); | ||
| // REQUIRE(r["z"].numAttributes() == 0); |
Check notice
Code scanning / CodeQL
Commented-out code Note test
Contributor
Author
|
TODO: Move this check into finalize, maybe only print a warning throw std::runtime_error(
"A Record can not be written without any contained "
"RecordComponents: " +
name); |
Member
|
@franzpoeschel is this for 0.18.0? :) |
Contributor
Author
Yup, this is still under development |
franzpoeschel
force-pushed
the
defaults-upon-close
branch
from
January 16, 2026 14:41
0f1d020 to
2115ede
Compare
franzpoeschel
force-pushed
the
defaults-upon-close
branch
from
January 19, 2026 15:08
941b3fd to
03b283b
Compare
franzpoeschel
force-pushed
the
defaults-upon-close
branch
from
January 28, 2026 13:22
99b4e3c to
bca3a85
Compare
franzpoeschel
force-pushed
the
defaults-upon-close
branch
from
January 29, 2026 19:31
6e14b44 to
489520d
Compare
franzpoeschel
force-pushed
the
defaults-upon-close
branch
from
February 2, 2026 11:11
ac83ce3 to
23dae9e
Compare
franzpoeschel
force-pushed
the
defaults-upon-close
branch
from
February 4, 2026 16:59
b03a47e to
d4475e5
Compare
franzpoeschel
force-pushed
the
defaults-upon-close
branch
from
February 9, 2026 10:51
d4475e5 to
1c87e86
Compare
Member
|
@franzpoeschel sorry small conflict in |
franzpoeschel
force-pushed
the
defaults-upon-close
branch
from
February 17, 2026 18:41
1c87e86 to
996051d
Compare
franzpoeschel
force-pushed
the
defaults-upon-close
branch
2 times, most recently
from
February 26, 2026 13:33
99f8758 to
7ef8956
Compare
available on all attributables
franzpoeschel
force-pushed
the
defaults-upon-close
branch
from
May 19, 2026 15:36
65e395f to
c7299f5
Compare
ax3l
approved these changes
Jun 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #1439
This PR focuses on Iteration-level attributes (including attributes included below Iteration level)
Needed for introducing a synchronous mode
TODO:
finalize()method publically, so users can request openPMD to set defaults nowflush()(benefit: early readers get readable datasets) or uponclose()(benefit: we do populate too eagerly, users might add defaults late)populateDefaultMetadata()