Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add border to Answers in Results table for visibility #88

Merged
merged 1 commit into from
May 15, 2024

Conversation

christophblessing
Copy link
Collaborator

@christophblessing christophblessing commented May 15, 2024

Description

This PR includes cosmetic adjustments to the Answers in the Result component. Every answer is surrounded by a coloured border for better visibility.

Screenshot 2024-05-15 at 13 51 45

This also resolves using the same background on hover as described in the original issue.

Decisions / Choices I made

We discussed various other design approaches but none of them were found aesthetically pleasing.

Checklist

  • All checks pass successfully
  • All related commits are squashed together
  • The changes are properly documented / the relevant documentation is updated (if applicable)
  • Appropriate labels are added to this pull request

@christophblessing christophblessing force-pushed the cb/hover-color-adjustments branch from 701984a to 22f0a2e Compare May 15, 2024 07:31
@christophblessing christophblessing changed the title Cb/hover color adjustments Add border to Answers May 15, 2024
@christophblessing christophblessing changed the title Add border to Answers Add border to Answers for visibility May 15, 2024
@christophblessing christophblessing added the enhancement New feature or request label May 15, 2024
@christophblessing christophblessing marked this pull request as ready for review May 15, 2024 08:15
To avoid using the same as the background color on hover,
it's additionally put on a white background.
The border is implemented with a relative value of the neutral-light color.

Part of XI-6385
@christophblessing christophblessing force-pushed the cb/hover-color-adjustments branch from 22f0a2e to 69df163 Compare May 15, 2024 11:49
@christophblessing christophblessing changed the title Add border to Answers for visibility Add border to Answers in Results table for visibility May 15, 2024
@christophblessing christophblessing merged commit 05ab5ef into main May 15, 2024
4 checks passed
@christophblessing christophblessing deleted the cb/hover-color-adjustments branch May 15, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants