[XI-6385] Change the set of questions the user can start the quiz with #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The user can now choose between 3 fixed sets (10, 20, 50) and the complete set. The complete set is always the option with the most questions. If any of the fixed sets is larger we don't show it. Adjust and extend tests. Closes #82
We don't need to create new data objects for test subsets. We can use the existing testData object and slice it to the required size.
JuliaCasamitjana
force-pushed
the
jc/6385_change_sets
branch
from
dd41713 to
b784492
Compare
christophblessing
approved these changes
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
To make sure the name of the sets (quick, medium, large) are consistent with the number of questions we decided to make the sets fixed.
The user can now choose between 3 fixed sets (10, 20, 50) and the complete set. The complete set is always the option with the most questions. If any of the fixed sets is larger we don't show it.
Decisions / Choices I made
use the existing testData object and slice it to the required size.
Checklist