Styles refinement #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure elements have font sizes to match the rest of the application font-sizes. Decrease buttons font size.
Also, the margin is set to the hint element, avoiding the overly complicated first-child selector
We now use the space-between property instead of the flex-grow. This prevents code elements from taking all horizontal space.
christophblessing
approved these changes
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes some styling issues and other style improvements:
Commit 1: Sets the
font-sizeproperty to elements that had none defined and could potentially be overwritten with values that did not match the rest of the styles. This commit also decrease the buttons font-sizeDetails
Commit 2: Improve display of codeblocks:
Details
Commit 3: Multiline answers were not properly displayed
Details
Commit 4: Prevent hint text from moving down to a new line. (See "Incorrect" hint from image above)
Commit 5: Prevents code elements from taking all horizontal space and ensures space between hint and text. Fixes: https://dev.xikolo.de/youtrack/issue/XI-6369#focus=Comments-71-49361.0-0
Details
ulelement. Otherwise they can be overwritten by external CSS. Fixes: https://dev.xikolo.de/youtrack/issue/XI-6369#focus=Comments-71-49374.0-0Decisions / Choices I made
Checklist