[XI-6368] Enhance results page #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JuliaCasamitjana
force-pushed
the
jc/XI-6368_enhance_results_page
branch
from
95ac4f4 to
c9dcd34
Compare
JuliaCasamitjana
force-pushed
the
jc/XI-6368_enhance_results_page
branch
from
c9dcd34 to
03a3b8f
Compare
|
As discussed, let's try to implement without reusing the
|
JuliaCasamitjana
force-pushed
the
jc/XI-6368_enhance_results_page
branch
from
03a3b8f to
6fea0e2
Compare
Rows can now be expanded or collapsed by clicking them. A chevron icon indicates the state. When collapsed, the question text truncates to one line and it becomes fully visible when the row is expanded. Markdown styles are reset to maintain the same font size and for the collapsed state they adopt the paragraph style (no colors, font weight, underlines...)
JuliaCasamitjana
force-pushed
the
jc/XI-6368_enhance_results_page
branch
from
6fea0e2 to
63da2b2
Compare
christophblessing
requested changes
Apr 30, 2024
JuliaCasamitjana
force-pushed
the
jc/XI-6368_enhance_results_page
branch
from
63da2b2 to
9decffb
Compare
The component style is based on the question and answers component. Specific answers can highlighted. We use it to display the last selection the user made. For that we need to extend the ResultType with a selections property. This property will be updated every time the user submits an answer. Extend result component tests and update documentation
Remove reference heading and replace attempts heading with icon on mobile view
JuliaCasamitjana
force-pushed
the
jc/XI-6368_enhance_results_page
branch
from
9decffb to
65e1baa
Compare
christophblessing
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR enhances the results table by:
Commit 1: Introducing collapse/expand functionality for table rows. It truncates the questions text to 1 line in the collapsed state. For this we create the
ResultsRowcomponent.Commit 2: Including answers with the last user selection. For this we create the
ResultViewercomponent, which contains a representation of the question and answers form but in a static way.It also improves the responsiveness (commit 3)
See mobile view
Decisions / Choices I made
Markdown styles are reset to maintain the same font size and for the collapsed state they adopt the paragraph style (no colours, no font weight, no underline...)
To include a representation of non-checked radio and checkboxes the regular font awesome package is required.
Since the
ResultViewercomponent is rather straightforward (not too much logic is involved), we're including its testing into the Results test. This way, we can also verify that the collapsed state gets passed from the entire row to theResultViewercomponent.Checklist