Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix space for image showing up in results table #108

Merged
merged 1 commit into from
May 29, 2024

Conversation

christophblessing
Copy link
Collaborator

@christophblessing christophblessing commented May 22, 2024

Description

This PR aims to resolve the problem described in #107.
If there is a text before an image, it will be shown too large in the results table.

Decisions / Choices I made

For a universal solution, I decided to hide every element but the first.
This way, we reduce potential error sources.

Checklist

  • All checks pass successfully
  • All related commits are squashed together
  • The changes are properly documented / the relevant documentation is updated (if applicable)
  • Appropriate labels are added to this pull request

This happens if there is a text before an image.
For a broader solution, we hide every element but the first.

Resolves #107
@christophblessing christophblessing force-pushed the fix-result-table-truncation branch from daf552d to ef31e7c Compare May 22, 2024 14:44
@christophblessing christophblessing marked this pull request as ready for review May 23, 2024 09:31
@christophblessing christophblessing added the bug Something isn't working label May 23, 2024
@christophblessing christophblessing merged commit b436c30 into main May 29, 2024
4 checks passed
@christophblessing christophblessing deleted the fix-result-table-truncation branch May 29, 2024 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants