[DS-1656] Add a new field 'Alert Style' for Alert nodes #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aleevas
force-pushed
the
DS-1656
branch
5 times, most recently
from
48ad0fb to
c8775b4
Compare
aleevas
changed the title
rollki
reviewed
Nov 20, 2024
| /** | ||
| * Implements hook_form_FORM_ID_alter(). | ||
| */ | ||
| function openy_node_alert_form_node_alert_edit_form_alter(array &$form, FormStateInterface $form_state, $form_id) { |
There was a problem hiding this comment.
Let's apply the DRY principle here and avoid code duplication.
Something like:
$fields_to_toggle = [
'field_alert_color',
'field_alert_text_color',
'field_alert_icon_color',
];
foreach ($fields_to_toggle as $field_name) {
$form[$field_name]['widget']['#states'] = [
'visible' => [
':input[name="field_alert_style"]' => ['value' => 'classic'],
],
];
}
rollki
reviewed
Nov 20, 2024
openy_node_alert.install
Outdated
Comment on lines
420
to
437
| $configs = [ | ||
| 'field.field.node.alert.field_alert_color' => [ | ||
| 'required', | ||
| ], | ||
| 'field.field.node.alert.field_alert_icon_color' => [ | ||
| 'required', | ||
| ], | ||
| 'field.field.node.alert.field_alert_text_color' => [ | ||
| 'required', | ||
| ] | ||
| ]; | ||
| $config_updater = \Drupal::service('openy_upgrade_tool.param_updater'); | ||
| foreach ($configs as $config_name => $params) { | ||
| $config = $config_dir . $config_name . '.yml'; | ||
| foreach ($params as $param) { | ||
| $config_updater->update($config, $config_name, $param); | ||
| } | ||
| } |
There was a problem hiding this comment.
OPTIONAL:
Can also be more compact:
$configs = [
'field.field.node.alert.field_alert_color',
'field.field.node.alert.field_alert_icon_color',
'field.field.node.alert.field_alert_text_color',
];
foreach ($configs as $config_name) {
$config_file = $config_dir . $config_name . '.yml';
$config_updater->update($config_file, $config_name, 'required');
}
|
Thanks @aleevas |
podarok
reviewed
Nov 21, 2024
podarok
reviewed
Nov 21, 2024
podarok
reviewed
Nov 21, 2024
podarok
reviewed
Nov 21, 2024
podarok
reviewed
Nov 21, 2024
podarok
reviewed
Nov 21, 2024
podarok
reviewed
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "How to check" instructions are included in the Jira issue DS-1656 .