Merged
Conversation
Will be left to follow-up PR.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
The changes in packages/shared/src/bounties.ts are generally good, replacing existentialDeposit with the more appropriate bountyValueMinimum and parameterizing tests with a testConfig object. However, there is a stylistic issue with function call formatting that impacts readability.
rockbmb
force-pushed
the
bounties-in-kusama-ah
branch
from
2abe5b1 to
12b1326
Compare
`proxy.ProxyExecuted` event is enough for analysis to make the test robust.
rockbmb
force-pushed
the
bounties-in-kusama-ah
branch
from
12b1326 to
3e17e60
Compare
Collaborator
Author
|
@xlc Would also appreciate a review here. Thanks is advance! |
Contributor
|
No issues found |
xlc
approved these changes
Oct 15, 2025
Also, the polkadot bounties E2E test tree instantiation mistakenly used a parachain test tree configuration.
The CI runners and my local machine disagree on the results of a test. The introduced workflow is to have a lower turnarround time for debugging.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #440 .
@dhirajs0 See the body of that issue for the steps required to fix this; it'll be relevant for #409 and #439 .